[xy-chart] add renderLabel
to <BarSeries />
#147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃弳 Enhancements
<BarSeries />
for rendering labels via therenderLabel
anddefaultLabelProps
propsdatum
has alabel
property, it will have a label rendered out of the box using the amazing@vx/text
<Text />
component (which wrapssvg
text, etc.). labels are always rendered on top of theBar
s themeselves.@data-ui
theme), text anchors, and wrapping behavior, but you can override them by settingdefaultLabelProps
to your own object.renderLabel
function with the signature({ datum, index, labelProps }) => node
.labelProps
includes all values fromdefaultLabelProps
as well as "smart" default values forwidth
,x
,y
,dx
,dy
,verticalAnchor
, andtextAnchor
based on bar position, size, and orientation (horizontal vs vertical)@vx/text
<Text />
component to support rendering custom labels.馃挃 Breaking Changes
<PointSeries />
label API to match<BarSeries />
(these are the only series types that support Labels).labelComponent
was replaced withrenderLabel
anddefaultLabelProps
TODO
cc @conglei @kristw @rmusa