-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added examples for export #1581
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1581 +/- ##
==========================================
- Coverage 99.70% 99.69% -0.02%
==========================================
Files 71 71
Lines 6854 6860 +6
==========================================
+ Hits 6834 6839 +5
- Misses 20 21 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Good idea, but can you add something to the script which writes what is being exported? Otherwise folk will run the script and not be aware it has done anything... |
@willmcgugan fixed it |
What I meant was informing the user what the script is doing. For instance:
Otherwise you would have no idea that it created some files. |
@willmcgugan got it. I think it looks good now. |
Looks good. Thanks! |
Type of changes
Checklist
Description
Added examples for export features provided by console.