Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples for export #1581

Merged
merged 6 commits into from
Oct 16, 2021
Merged

Conversation

sureshdsk
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Added examples for export features provided by console.

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1581 (5dddadb) into master (3f192d3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1581      +/-   ##
==========================================
- Coverage   99.70%   99.69%   -0.02%     
==========================================
  Files          71       71              
  Lines        6854     6860       +6     
==========================================
+ Hits         6834     6839       +5     
- Misses         20       21       +1     
Flag Coverage Δ
unittests 99.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/pager.py 90.00% <0.00%> (-10.00%) ⬇️
rich/json.py 100.00% <0.00%> (ø)
rich/text.py 100.00% <0.00%> (ø)
rich/tree.py 100.00% <0.00%> (ø)
rich/table.py 100.00% <0.00%> (ø)
rich/prompt.py 100.00% <0.00%> (ø)
rich/console.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2566979...5dddadb. Read the comment docs.

@willmcgugan
Copy link
Collaborator

Good idea, but can you add something to the script which writes what is being exported?

Otherwise folk will run the script and not be aware it has done anything...

@sureshdsk
Copy link
Contributor Author

@willmcgugan fixed it

@willmcgugan
Copy link
Collaborator

What I meant was informing the user what the script is doing.

For instance:

Wrote "html_export.html"

Otherwise you would have no idea that it created some files.

@sureshdsk
Copy link
Contributor Author

@willmcgugan got it. I think it looks good now.

@willmcgugan
Copy link
Collaborator

Looks good. Thanks!

@willmcgugan willmcgugan merged commit eb673d1 into Textualize:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants