Merge pull request #228 from mindnektar/fix/issue-182

fix: add px to positional css values for ios devices
willmcpo · Aug 14, 2021 · 79c4cf2 · 79c4cf2
2 parents 157d235 + 5b3ffa2
commit 79c4cf2
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 15 deletions.
diff --git a/lib/bodyScrollLock.es6.js b/lib/bodyScrollLock.es6.js
@@ -102,11 +102,11 @@ const setPositionFixed = () => window.requestAnimationFrame(() => {
       left: document.body.style.left
     };
 
-    // Update the dom inside an animation frame 
+    // Update the dom inside an animation frame
     const { scrollY, scrollX, innerHeight } = window;
     document.body.style.position = 'fixed';
-    document.body.style.top = -scrollY;
-    document.body.style.left = -scrollX;
+    document.body.style.top = `${-scrollY}px`;
+    document.body.style.left = `${-scrollX}px`;
 
     setTimeout(() => window.requestAnimationFrame(() => {
       // Attempt to check if the bottom bar appeared due to the position change

diff --git a/lib/bodyScrollLock.esm.js b/lib/bodyScrollLock.esm.js
@@ -105,15 +105,15 @@ var setPositionFixed = function setPositionFixed() {
         left: document.body.style.left
       };
 
-      // Update the dom inside an animation frame 
+      // Update the dom inside an animation frame
       var _window = window,
           scrollY = _window.scrollY,
           scrollX = _window.scrollX,
           innerHeight = _window.innerHeight;
 
       document.body.style.position = 'fixed';
-      document.body.style.top = -scrollY;
-      document.body.style.left = -scrollX;
+      document.body.style.top = -scrollY + 'px';
+      document.body.style.left = -scrollX + 'px';
 
       setTimeout(function () {
         return window.requestAnimationFrame(function () {

diff --git a/lib/bodyScrollLock.js b/lib/bodyScrollLock.js
@@ -134,15 +134,15 @@
           left: document.body.style.left
         };
 
-        // Update the dom inside an animation frame 
+        // Update the dom inside an animation frame
         var _window = window,
             scrollY = _window.scrollY,
             scrollX = _window.scrollX,
             innerHeight = _window.innerHeight;
 
         document.body.style.position = 'fixed';
-        document.body.style.top = -scrollY;
-        document.body.style.left = -scrollX;
+        document.body.style.top = -scrollY + 'px';
+        document.body.style.left = -scrollX + 'px';
 
         setTimeout(function () {
           return window.requestAnimationFrame(function () {

diff --git a/lib/bodyScrollLock.min.js b/lib/bodyScrollLock.min.js
diff --git a/src/bodyScrollLock.js b/src/bodyScrollLock.js
@@ -115,12 +115,12 @@ const setPositionFixed = () => window.requestAnimationFrame(() => {
       top: document.body.style.top,
       left: document.body.style.left
     };
- 
-    // Update the dom inside an animation frame 
+
+    // Update the dom inside an animation frame
     const { scrollY, scrollX, innerHeight } = window;
     document.body.style.position = 'fixed';
-    document.body.style.top =  -scrollY;
-    document.body.style.left = -scrollX; 
+    document.body.style.top = `${-scrollY}px`;
+    document.body.style.left = `${-scrollX}px`;
 
     setTimeout(() => window.requestAnimationFrame(() => {
       // Attempt to check if the bottom bar appeared due to the position change
@@ -241,7 +241,7 @@ export const clearAllBodyScrollLocks = (): void => {
     // Reset initial clientY.
     initialClientY = -1;
   }
-  
+
   if (isIosDevice) {
     restorePositionSetting();
   } else {