Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scrolling on both axes (iOS) #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xanido
Copy link

@xanido xanido commented Sep 18, 2019

Currently, enabling bodyScrollLock disables scrolling on anything but the targetElement. However, on iOS, it also locks scrolling to the Y axis, preventing horizontal scrolling on the targetElement.

This PR allows scrolling on either axis on the targetElement.

@kubmir
Copy link

kubmir commented Nov 6, 2019

@willmcpo Hello, how does it look with this PR? Will it be released? I would like to use horizontal scrolling. Thanks for the answer.

@Aarbel
Copy link

Aarbel commented Mar 25, 2020

@willmcpo please help 🙏

@Aarbel
Copy link

Aarbel commented Mar 25, 2020

@xanido the horizontal scroll seems to still be frozen if the target can only scroll horizontally.

Have you tested this case ?

@Aarbel
Copy link

Aarbel commented Mar 25, 2020

Moreover @xanido looks like @willmcpo works in Qantas company in Sydney, so if you want to target him directly to update this repo, you're very close

@willmcpo
Copy link
Owner

Hi all, will look into this PR soon

@Aarbel
Copy link

Aarbel commented Mar 25, 2020

Thanks a lot @willmcpo, sorry again for the multiple pings

@Aarbel
Copy link

Aarbel commented Mar 25, 2020

@xanido the horizontal scroll seems to still be frozen if the target can only scroll horizontally.

Have you tested this case ?

@willmcpo i think you should also check this

@drosi94
Copy link

drosi94 commented Aug 17, 2021

Hey people! is this PR going to be merged soon? I really need this so maybe I need to implement it by myself it it's not going to be merged.
Thank you!

@willmcpo
Copy link
Owner

@xanido the horizontal scroll seems to still be frozen if the target can only scroll horizontally.
Have you tested this case ?

@willmcpo i think you should also check this

is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants