#90 fix not worked enableBodyScroll in some conditions

[An-Cu]

here is commit to fix issue #90

[willmcpo]

why do we need to run this for even ios devices?

[An-Cu]

@willmcpo I don't tested changes on iOS.
Anyway the same issue can appear on any device, so I assume that this change is required for iOS devices too.

[willmcpo]

Ios doesnt call setOverflowHidden so restore does not need to be called for Ios

…

On Sun, Jun 16, 2019, 11:52 PM An-Cu ***@***.***> wrote: In src/bodyScrollLock.js <#91 (comment)> : > locks = []; > } else { > locks = locks.filter(lock => lock.targetElement !== targetElement); > } > + > + if (!locks.length) { > + restoreOverflowSetting(); @willmcpo <https://github.com/willmcpo> I don't tested changes on iOS. Anyway the same issue can appear on any device, so I assume that this change is required for iOS devices too. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/willmcpo/body-scroll-lock/pull/91/files/3eae730b46d185e73f7575779c4bd5afbd60d38e?email_source=notifications&email_token=ADJPCOT2H2SENIABFP63R6DP2ZAS5A5CNFSM4GSWTZ52YY3PNVWWK3TUL52HS4DFXBIHK3DMKJSXC5LFON2FEZLWNFSXOQ3PNVWWK3TUVJRW63LNMVXHIX3JMTHBDB3C4U#r294085349>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJPCORRWE2J7XEQQXOPY4LP2ZAS5ANCNFSM4GSWTZ5Q> .

[An-Cu]

I can change condition and check if overflow hidden was set and only then invoke restoreOverflowSetting. But moving restoreOverflowSetting to condition above is bad idea, because then code will be more complicated and unreadable through adding same piece of code inside else and else if blocks.( WET vs. DRY principle)

[willmcpo]

Refer to my comment about removing else if block

…

On Mon, Jun 17, 2019, 2:28 PM An-Cu ***@***.***> wrote: I can change condition and check if overflow hidden was set and only then invoke restoreOverflowSetting. But moving restoreOverflowSetting to condition above is bad idea, because then code will be more complicated and unreadable through adding same piece of code inside else and else if blocks.( WET vs. DRY principle) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#91?email_source=notifications&email_token=ADJPCOWGCVKW6MF5S56GT5TP24HGPA5CNFSM4GSWTZ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2ACQQ#issuecomment-502530370>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJPCOXW2VAA5TD6JADIR2TP24HGPANCNFSM4GSWTZ5Q> .

[An-Cu]

Ok it seems good for me.
Sorry for misunderstanding.

I will add commit on Wednesday.

[An-Cu]

@willmcpo I updated pull-request.

[willmcpo]

thanks for the fix @An-Cu