Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding .forRoot() method #48

Merged

Conversation

willmendesneto
Copy link
Owner

Please check if the PR fulfills these requirements

  • The commit messages follow these
    guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other. Please describe:

If it is a Bugfix, please describe the root cause and what could have been done to prevent it…

What is the current behavior? (You can link to an open issue here, add screenshots…)

N/A

What is the new behavior?

Usage:

import { NgModule } from '@angular/core';
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
// ... list of other app dependencies

import { AppComponent } from './app.component';
// ... list of other app components/modules

@NgModule({
  declarations: [AppComponent],
  imports: [NgxSkeletonLoaderModule.forRoot()],
  providers: [],
  bootstrap: [AppComponent],
})
export class AppModule {}

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@willmendesneto willmendesneto merged commit a2d08f2 into master Nov 15, 2020
@willmendesneto willmendesneto deleted the willmendesneto/adding-ngx-skeleton-loader-in-resources branch November 15, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant