-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global custom properties no longer showing up #52
Comments
It clearly looks like the parser is failing to parse the CSS file, which shouldn't be the case, as I released a safe-parser which should work for any type of file. Can you help with the following details:
Also, to understand your
In your config, I am not sure what does |
You can also refer to the examples, if your vscode settings are correctly set or not 👍🏾 |
Thanks @phoenisx I have a bunch of errors like these: Currently, it's now working but only within css files. However, between the I did the obvious thing and restarted my computer. That made no difference. |
I tried on VS Codium too. No errors, but doesn't work with Astro files either. I just saw a previously closed issue regarding Open-Props. SO, it seems it's not picking up Open-Props custom props in .astro files, but it picks them up in .css files. According to the Open-Props' VS Code instructions (https://open-props.style/#getting-started), it should be set up as:
Is that correct? I already tried that. |
Is this the project: https://github.com/djmtype/astro-xenon that fails to parse the Anyways, I need to raise a PR to update Open-Props docs, because there has been some recent changes that by default ignores scanning Due to this you will have to provide: {
// Do not ignore node_modules, which is ignored by default
"cssvar.ignore": []
} You can refer to this example for better understanding. |
@phoenisx That's the repo, but it's the open-props branch. https://github.com/djmtype/astro-xenon/tree/open-props It's still not offering css variables suggestions. In conclusion works well with css files. But, files where css exists inside a |
Hi @djmtype What is the extension of the file where you are not seeing any intellisense? Can you share a short video clip or a reproduction of the issue that you are facing? |
@phoenisx CSS Vars currently isn't showing suggestions from local css files or node modules on any .astro file within a <style> tag. I'll gladly share a screencast clip. I'll get to it a bit later today. |
@phoenisx I figured out my issue – me, or my muscle memory. In CSS files, it works either way by typing However, I wouldn't change a thing. I just need to train my brain. I still don't why I get the errors as seen above. #52 (comment) I'll try doing more debugging with these. |
I feel the issue is with using PostCSS plugin, as raised earlier #38 (comment) Can you try disabling the PostCSS plugin and try once 👍 |
Hi @djmtype Were u able to find details on the issue? Was any other extension causing conflict with this one? Also, I wanted to know, Are you working on a local file system or a remote file system project? |
Hey @phoenisx I'm just working on a local project. |
I don't know if the update broke something. But, 2 days ago, this extension was working great. It was able to pick up all my css custom properties. Now, it doesn't seem to work. Only intellisense picks up on the custom properties I've used within the same file.
I tried re-enabling the extension and rechecking its settings. I just added
"cssvar.files": ["**/*.css"]
, but it made no difference.Here are my settings:
It fails in .astro files without an alert. Within .css files, I get the screenshot attached:
The text was updated successfully, but these errors were encountered: