Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pick): release taken letters when deleting buffers #112

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

soifou
Copy link
Contributor

@soifou soifou commented Jun 3, 2023

When all available letters get assigned to buffers, a question mark (?)
starts to appear for each new one. The pick feature is then unusable
anymore for the upcoming buffers, even if we delete those with assigned
letters.

This PR simply release the assigned letter of a deleted buffer.

When all available letters get assigned to buffers, a question mark (?)
starts to appear for each new one. The pick feature is then unusable
anymore for the upcoming buffers, even if we delete those with assigned
letters.

This PR simply release the assigned letter of a deleted buffer.
Copy link
Owner

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@willothy willothy merged commit dce9f06 into willothy:master Jun 3, 2023
4 checks passed
@soifou soifou deleted the release-taken-letter branch June 3, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants