Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fill_hl config option #114

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

folliehiyuki
Copy link
Contributor

Make the colors of the filler space configurable.

From :h syntax.txt, I think we should use TabLineFill instead of TabLine. This might break people's tabline color, so I make the highlight group a config option and naively pass it to the render() function.

							*hl-TabLine*
TabLine		Tab pages line, not active tab page label.
							*hl-TabLineFill*
TabLineFill	Tab pages line, where there are no labels.

@willothy
Copy link
Owner

willothy commented Jun 14, 2023

This change makes sense to me overall, I don't think the config variable makes sense to pass to render() though. It's already in the global config table, we can just use the global from within render() instead. I'll look over this in more detail tonight though.

Make the colors of the filler space configurable.
Copy link
Owner

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@willothy willothy merged commit 7ec240f into willothy:main Jun 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants