Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: index update value #118

Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix: index update value #118

merged 2 commits into from
Jun 20, 2023

Conversation

Equilibris
Copy link
Contributor

@Equilibris Equilibris commented Jun 20, 2023 •
edited

@Equilibris Equilibris mentioned this pull request Jun 20, 2023
Closed
willothy
willothy approved these changes Jun 20, 2023
View reviewed changes
Copy link
Owner

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Equilibris
Copy link
Contributor Author

Is Luacheck working btw? It's been hanging for quite some time

@willothy
Copy link
Owner

willothy commented Jun 20, 2023 •
edited

Is Luacheck working btw? It's been hanging for quite some time

Yeah, it's been doing that a lot recently. I'll merge without it finishing in a few mins if it keeps on going. Considering switching to Selene for CI.
Just had to edit the CI workflow, it was still relying on the old master branch. Oops!

@willothy willothy merged commit cb4bbdf into willothy:main Jun 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willothy willothy willothy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Equilibris @willothy