Reuse pick letters #186
Merged
Reuse pick letters #186
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `first_valid` a function-level variable rather than a module-level
one. This way when buffers are deleted, the letters at the begining of
the list are re-used.
This improves the UX when `use_filename` is false:
- The letters at the begining of the list are likely to be the best
ones. My setup puts the home row keys at the start.
- Otherwise, if you keep deleting buffers you can use up all the
letters and get `?` for all your buffers.
bendk
force-pushed
the
reuse-pick-letters
branch
from
9844fae
to
97da465
Compare
|
Thanks for the PR! Looks good at first glance, and the change makes sense - I'll test it out and merge later today :) |
willothy
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
first_valida function-level variable rather than a module-level one. This way when buffers are deleted, the letters at the begining of the list are re-used.This improves the UX when
use_filenameis false:?for all your buffers.