New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for Windows always fails when computing `unique_prefix` #65

Merged

noib3 merged 1 commit into willothy:master from EtiamNullam:fix/unique-prefix-windows

May 15, 2022

Contributor

EtiamNullam commented May 14, 2022

not fn.has("win32") == 0 is always false even on Windows, as:

fn.has("win32") returns 1 or 0
both not 1 and not 0 evaluate to false as numbers always evaluate to true in lua
false == 0 is always false

Basically it would needs braces but it can also have this simple form:

fn.has("win32") == 1

So it seems like its broken on Windows since 9fd956f (v0.1.0), possibly during refactor.


          fix: check for Windows always fails when computing unique_prefix

8bb3fb3

noib3 merged commit 4275523 into willothy:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment