Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate internal code loading; add runtime inclusion option. #1

Closed

Conversation

willow-ahrens
Copy link
Owner

This change would deprecate the custom code loading in MatrixDepot. In particular, this makes three key changes:

  1. MatrixDepot will no longer create or write to MYDEPOT. While MatrixDepot still reads these files, it will issue a deprecation warning if they are not the default files.
  2. MatrixDepot no longer serializes user-defined generators because they may or may not be loaded when the database is deserialized
  3. The Documentation now explains the replacement functionality, which directs users to call include_generator from outside of MatrixDepot at runtime, then reinitialize.

@willow-ahrens
Copy link
Owner Author

Note that we cannot remove the code associated with determining the path of MYDEPOT until we move from deprecation to removal at some point in the future.

@KlausC
Copy link

KlausC commented Jun 10, 2021

This PR is targeting only your clone of https://github.com/JuliaMatrices/MatrixDepot.jl, what explains, that we did not receive notifications.

@willow-ahrens
Copy link
Owner Author

willow-ahrens commented Jun 10, 2021

That's correct, this is a PR on a PR (JuliaLinearAlgebra#75). If you'd prefer, I can retarget this as a PR directly to MatrixDepot after JuliaLinearAlgebra#75 is merged.

@willow-ahrens
Copy link
Owner Author

These changes have been moved to JuliaLinearAlgebra#79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants