Fix TypeError in PubSubClass.unsubscribe #44
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying an array while iterating over it is tricky. If we delete an
element in the middle and continue to iterate using the old length,
we'll perform an access beyond the end of the array, get back an
undefined
, and then get a TypeError when we try to[0]
it.I've seen this in the wild, when attempting to show a popup that
embeds jSignature for the second time on the same page. The
error is uncaught and disables all subsequent JavaScript on the
page.
I don't know if this method was meant to remove just the first matching
callback, or all of them. My modification assumes the first; if you
need the second, instead of break do
i--; l--
.