#73 Alphabetically sort modules in the hyperion list #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alphabetical is a fine default. It'd be ideal to list plugins in the order they're listed in Gradle's dependencies list. Maybe it influences class loading order? |
|
That isn't really possible as dependencies end up in a graph that doesn't really guarantee order of definition rather order of requirement. It would be possible to allow defining in a few various ways what the preferred order is, however, I'm not sure how much value that really has. |
|
Yeah, I think it's more important that you just be able to find the tool you need quickly. Maybe alphabetical for now, and if we ever have like twenty plugins, type to filter? |
|
Agree that class name is fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #73
This is probably 'good enough' but I'm open to input on how to make this better. I would prefer plugins define their names explicitly, however, I think I created a good enough fallback as it seems most plugin classes are well named.