Decoupling #124
Open
Decoupling #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrk-han
reviewed
Aug 28, 2019
mrk-han
reviewed
Aug 28, 2019
|
It's hard to see the changes here because of the changes in develop. Can you rebase/merge them? |
Started decoupling functionality from the main Locomotiveô class
removing .classpath file tracking Updated gitignore to not track .classpath files
|
@evant done, my bad, used to doing trunk based development and I forget that |
mrk-han
reviewed
Aug 28, 2019
| return isPresentWait(PageUtil.buildBy(config, id)); | ||
| } | ||
|
|
||
| public boolean isPresentWait(By by) { |
There was a problem hiding this comment.
This is the functionality pre-0.19.0, something may have gotten hecked up
There was a problem hiding this comment.
yeah you are right, I must've hecked something up with the rebase. I wanted to keep the Conductor class name going forward but yeah I hecked it up.
…tion (#113) * Refactor isPresentWait * Add Exceptions to error messages * Remove old isPresentWait() tests - test_is_present_wait_retries_and_fail() - test_is_present_wait_retries_and_find_item() They were testing an old implementation with custom logic. Now we are only giving a wrapper around battle tested Appium methods so none are needed right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Put issue number in this format
closes #XXXXto auto-close the issue or task this PR addresses (if true).Description
Please write a short description of your changes.
Additional Info
Provide any additional info here.
Checklist