Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lazy evaluation for all dependencies #3

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Support lazy evaluation for all dependencies #3

merged 5 commits into from
Feb 1, 2024

Conversation

moyerr
Copy link
Collaborator

@moyerr moyerr commented Feb 1, 2024

  • Use @autoclosure to support lazy evaluation for all dependencies, not just those that require a setup closure
  • Use ObjectIdentifier as the key type

rafcabezas
rafcabezas reviewed Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@rafcabezas rafcabezas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you Robbie. Would you be able to update the README.md as well to match? 🙏

Sources/Grove/Grove.swift Show resolved Hide resolved
Sources/Grove/Grove.swift Show resolved Hide resolved
@moyerr
Copy link
Collaborator Author

moyerr commented Feb 1, 2024

@rafcabezas Done! ✅

rafcabezas
rafcabezas approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@rafcabezas rafcabezas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 ⭐

@moyerr moyerr merged commit 9e04bbe into main Feb 1, 2024
@moyerr moyerr deleted the moyerr/lift-reference-type-restriction branch February 1, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafcabezas rafcabezas rafcabezas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moyerr @rafcabezas