Switch Development over to OpenSource #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement inline sort function * Add helper methods for vertical and horizontal distance to CGPoint * Add inline sorting function to example app
* Add continuous & weighted continuous sort functions * Add continuous sort functions to example * Make property for squares per row in example VCs
Documentation/sort functions
Layout storyboard for sort function test view Set test controller as initial for development Add temp child vc Set frame for test view controller implement stackview for easy button hiding Add SortFunctionTestSettings Add initial target/actions Add switching on segment indices for position, corner Implement initial reloading of animation view Add direction field Add direction to settings as well Tweak slider values Wire up settings to test animation vc Add function to get proper sort for current settings Hide controls based on current sort function Fix some missing controls Fix several mismatched controls Fix unsatisfiable constraints Remove continuous slider updates, add reload on tap Add random sorting to test, restore table vc Improve picker's didSelectRow Slim down initial table vc Rename some components, remove some obsolete test classes Rename file for custom animatino vc Improve readability Update the theme of the example project Update the theme of the example project Added a scroll view for the smaller screens so that the bottom content won't be cutoff Pass the new design theme to all view controllers
Feature/example enhancements
Include the Animations Protocol references
Having a depth ability allows for a global cutoff to determine exactly how far the recursive search should go.
Added recursiveDepth rather than a boolean
One feature of Spruce is to allow the user to recursively grab subviews of a . However, for the sort functions to work properly, the coordinate spaces of all the subviews must be the same. So this feature was added to the method and a new type was introduced, . This struct is used to keep track of the actual reference point of the because if we were to change the point on the itself, the screen would change. Having this struct allows us to keep track of the reference point and make sure that there are no screen updates.
Rafactored the code for the example project so that it looks a little bit cleaner for production use. Started to add in the code generation section and will continue that in a subsequent PR. Removed the unnecessary files from the codebase because they wouldn't be used in the primary demo.
Now at the bottom of the tutorial page there will be a code preview of the sort function that you have created. We have seen a couple other animation apps that have this functionality so we wanted to add it in. The other piece is that when the sort function changes, the code is printed to the console. This makes sure it's really easy to copy if the developer wants to.
Now in the example app you can control the weights of the vertical and horizontal weights.
Adds in fastlane support so that integration with a public CI server will be easier. The main lane setup is the `run_tests` lane which will run all of the unit tests that are currently built into Spruce. As we add more and more tests, this functionality should remain the same. If we wanted to actually build and sign the example project ipa, then this is where we would also do that. We may want to consider adding in a step so that it does build the example project, just to make sure that it builds. Will discuss with Biscuit to see more of this.
Adds in the `circle.yml` file that will allow for the configuration of the CI server. Right now we only need to test the main `Spruce` project. No need for any building of ipa's.
Start to add in more unit tests for sort functions
Added reversed unit tests for RadialSortFunction
Removed all of the names and personally identifying traits from the code. For any file that didn't have a license on top, also added that comment. The code should now be prepared for production use in this sense.
QA had the idea of a close button for the sort function selector so that you can change whether or not you want to update the sort function. This was definitely beneficial and made the interface a little cleaner.
With all of the changes that are happening with Spruce we need to make sure that the README is updated. In this PR, I essentially re-write the entire README so that it is better formatted for the average user and provides more details into exactly what Spruce does.
Added a code of conduct file to the repo to make sure that those contributing and commenting on the repo follow our guidelines.
…pproach Add computed variable approach to UIView
…-prefix Update naming scheme to prefix extension methods
Respond to PR Comments
Implement wrapping for the code preview
Update view layout for start selector
Fix issues with Memory Leak
…ns-documentation-4 Complete Documentation
…ns-documentation-3 Finished the full view documentation
…files Removed names from new files
Add code of conduct to the repo
Add Jazzy Docs
Update the README
…-example-app Add close function to sort function selector
Add iPad support to example app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.