Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[768] Encapsulate speech synthesizer, divorce from main queue #772

Merged

Conversation

Clstroud
Copy link
Collaborator

closes #768

  • Shuffles and consolidates storage of speech synthesizer
  • Converts synthesizer wrapper to an actor to fix most of the main thread warnings

Note: At least one such warning still occurs in the Xcode console from an internal API we have no influence over. I'm keeping my fingers crossed it will be resolved in a future Xcode update.

Copy link
Contributor

@stevefosterwta stevefosterwta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Clstroud Clstroud merged commit 5874de1 into develop May 22, 2024
6 checks passed
@Clstroud Clstroud deleted the task/768-fix-main-thread-checker-warnings-speech-synthesis branch May 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix main thread checker warnings from AVSpeechSynthesizer
2 participants