New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] toFactory implementation #71
Conversation
SieR-VR
commented
Sep 9, 2022
•
edited
edited
- implement Pipelines as generators #69
This reverts commit 8a32e52.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work! Thanks for taking this on, and sorry it took me a bit to get to it. I did finally get approval to keep working on this project under my full ownership, though, so that's good. I just a few small requests / suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll push out a new version after this gets merged.