Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This package now requires go1.21 #84

Closed
ncw opened this issue Oct 28, 2023 · 1 comment
Closed

This package now requires go1.21 #84

ncw opened this issue Oct 28, 2023 · 1 comment

Comments

@ncw
Copy link
Contributor

ncw commented Oct 28, 2023

In 2b12fc2 the go.mod go version was updated to go 1.21. This forces all users of this package to be using go 1.21 too.

So when I do this I get

$ go get github.com/willscott/go-nfs
go: upgraded go 1.19 => 1.21  // this changes the go statement in my go.mod
go: added toolchain go1.21.3
go: upgraded github.com/willscott/go-nfs v0.0.0-20230823072803-2b8e63b4d81f => v0.0.0-20231024182844-ccc7143570a1

This is undesirable for me as I wish to support go1.19, go1.20 and go1.21 as many distributions have older go version.

I will send a PR changing this back to 1.19 in a moment

Thank you

willscott added a commit that referenced this issue Oct 28, 2023
Revert go.mod version back to 1.19 - fixes #84
@willscott
Copy link
Owner

Thanks for raising/fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants