off-by-one issues with dir cookies #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note that this issue only emerged with #24, since before that commit the server would respond to read-dir requests with all entries in one over-sized response. |
|
found the potential issue on stale cookies, which is that when the root directory falls out of the file handle cache, bad things happen. Updated that handler to make sure it re-accesses the full directory path (somewhat inefficiently, admittedly) on accesses. I now cannot reproduce #24 on mac or linux clients. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue in accounting for the implicit
.and..entries in directory listings that was part of the issue in #26With this fix, I get the correct output on a linux machine. The described symptoms in #26 imply there may be a secondary issue in mac interactions, since it the disjoint of 27 vs 65 entries is likely that the subsequent pages of entries are not correctly fetched at all, not simply the off-by-two paging issue this commit fixes.