Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ansible_distribution_major_version in variables #132

Merged
merged 1 commit into from Sep 23, 2020
Merged

Use ansible_distribution_major_version in variables #132

merged 1 commit into from Sep 23, 2020

Conversation

noonedeadpunk
Copy link

@noonedeadpunk noonedeadpunk commented Sep 21, 2020

In order to collect variables, it's worth using
ansible_distribution_major_version as ansible_distribution_version
changes behaviour between ansible releases, ie [1]

This causes CentOS jobs fail with 2.8.13, as
ansible_distribution_version there is '7.8' [2]

This is partially reverts #115

[1] ansible/ansible#57463
[2] https://zuul.opendev.org/t/openstack/build/e5ae88e08ac546ccb0e7ab99f8f0a051/log/zuul-info/host-info.centos-7.yaml#141

In order to collect variables, it's worth using
ansible_distribution_major_version as ansible_distribution_version
changes behaviour between ansible releases, ie [1]

This causes CentOS jobs fail with 2.8.13, as
ansible_distribution_version there is '7.8' [2]

[1] ansible/ansible#57463
[2] https://zuul.opendev.org/t/openstack/build/e5ae88e08ac546ccb0e7ab99f8f0a051/log/zuul-info/host-info.centos-7.yaml#141
@mattwillsher
Copy link
Member

Thanks @noonedeadpunk

@mattwillsher mattwillsher merged commit fb231de into willshersystems:master Sep 23, 2020
@noonedeadpunk noonedeadpunk deleted the ansible_distribution_version branch September 23, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants