Unbreak FIPS detection and stabilize failing tests and GH actions #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add CentOS 9 * use better tasks names Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
This fixes up the commit 7f69d1e Signed-off-by: Jakub Jelen <jjelen@redhat.com>
…e drop-in directory Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
This fixes also a typo that was overlooked previously Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Previously no hostkeys were checked if they were not present in the generated configuration file. When the drop-in directory is used, usually, there are no hostkeys in that file and no sanity check for hostkeys was executed. This amends the "auto" value for the hostkeys check to allow checking for default hostkeys that are read by OpenSSH by default. Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
mattwillsher
approved these changes
Apr 11, 2022
richm
reviewed
Apr 11, 2022
richm
reviewed
Apr 11, 2022
richm
reviewed
Apr 11, 2022
richm
reviewed
Apr 11, 2022
richm
reviewed
Apr 11, 2022
richm
reviewed
Apr 12, 2022
Jakuje
force-pushed
the
unbreak-fips-detection
branch
from
073d4c5
to
7d977f8
Compare
|
Thank you for reviews. I filled roles-ansible/check-ansible-ubuntu-latest-action#2 for the failing ubuntu action to see if we can get it green before merging (It was working two days ago). Unfortunately, it was a bit larger than I initially expected. In any case, I will keep it open for some days before merging if some other review will pop up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of bugfix changes from #178