Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v0.16.1 - CHANGELOG.md [citest skip] #195

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

richm
Copy link
Collaborator

@richm richm commented Jul 28, 2022

[v0.16.1] - 2022-07-28

New Features

  • add parameter RSAMinSize

Add support for the new RSAMinSize parameter.

Bug Fixes

  • none

Other Changes

  • Addition notes about secondary variables
  • Fix various linting issues
  • Revert incorrect module name
  • tests: Do not be picky about spaces/tabs

When testing with cloud-init, it modifies the sshd_configuration and can
replace some tabs with whitespaces. This happens frequently around the
subsystem keyword. There are no functional changes, but the matching
did not work as expected.

Signed-off-by: Jakub Jelen jjelen@redhat.com

  • the role still supports ansible 2.9

  • Add CHANGELOG.md

  • Add changelog_to_tag.yml to .github/workflows

Description:
When a new changelog section is added to CHANGELOG.md and pushed,
changelog_to_tag.yml is triggered, which generates a new tag and
a new release.

Signed-off-by: Rich Megginson rmeggins@redhat.com

@richm richm mentioned this pull request Jul 28, 2022
@richm
Copy link
Collaborator Author

richm commented Jul 28, 2022

please hold until #196 is merged

@richm
Copy link
Collaborator Author

richm commented Jul 29, 2022

please hold until #196 is merged

Done. This can be merged now.

[v0.16.1] - 2022-07-28
--------------------

- add parameter RSAMinSize

Add support for the new RSAMinSize parameter.

- Ensure values are cast to correct type

- Addition notes about secondary variables
- Fix various linting issues
- Revert incorrect module name
- tests: Do not be picky about spaces/tabs

When testing with cloud-init, it modifies the sshd_configuration and can
replace some tabs with whitespaces. This happens frequently around the
subsystem keyword. There are no functional changes, but the matching
did not work as expected.

Signed-off-by: Jakub Jelen <jjelen@redhat.com>

- the role still supports ansible 2.9

- Add CHANGELOG.md

- Add changelog_to_tag.yml to .github/workflows

Description:
When a new changelog section is added to CHANGELOG.md and pushed,
changelog_to_tag.yml is triggered, which generates a new tag and
a new release.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@mattwillsher mattwillsher merged commit b75ef4c into willshersystems:master Aug 18, 2022
@mattwillsher
Copy link
Member

@richm @Jakuje this failed on the run on master determining the tag.

@mattwillsher
Copy link
Member

Looks to me like the action kept [] around the tag it derived from the changlog.

@richm richm deleted the cl-20220728 branch August 18, 2022 13:13
@richm
Copy link
Collaborator Author

richm commented Aug 18, 2022

Looks to me like the action kept [] around the tag it derived from the changlog.

Yep - probably a bug in parsing [vX.Y.Z] vs [X.Y.Z]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants