Makes drop-in functionality configurable by the user #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkakouros lint should be fixed on master I believe, so please merge/rebash that in to the test work. This change supercedes #199 ? |
nkakouros
changed the title
|
@mattwillsher Sorry, I was too sleepless to read properly, this is supposed to be a continuation of #199. I updated the title. I will rebase both PRs now. |
richm
reviewed
Aug 18, 2022
richm
reviewed
Aug 18, 2022
richm
reviewed
Aug 18, 2022
richm
reviewed
Aug 18, 2022
richm
reviewed
Aug 18, 2022
Jakuje
reviewed
Aug 20, 2022
Jakuje
reviewed
Aug 23, 2022
Jakuje
reviewed
Aug 25, 2022
Jakuje
approved these changes
Aug 29, 2022
|
Thank you for the patience! It looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of #199.
This PR simplifies the logic behind the drop-in config files and also allows the user to use drop-in configs even if the distribution does not support it out of the box.