Version v0.17.0 - CHANGELOG.md [citest skip] #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
reviewed
Sep 1, 2022
[v0.17.0] - 2022-08-31 -------------------- - Make drop-in config file functionality configurable by user This PR simplifies the logic behind the drop-in config files and also allows the user to use drop-in configs even if the distribution does not support it out of the box. - Allow user to override variables A previous commit hardcoded many variables to the values under vars/, making it impossible for the user to parameterize things like the systemd service name. The assumption was that the __sshd_* variables were useless in an effort to blindly adhere to best practices, but they were crucial in allowing flexibility to the user. - none
|
ok to merge? |
mattwillsher
approved these changes
Sep 7, 2022
|
auto tagging failed again. I'll manual tag this and the previous release. |
|
Released to galaxy. #203 raised for linting fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[v0.17.0] - 2022-08-31
New Features
This PR simplifies the logic behind the drop-in config files and also
allows the user to use drop-in configs even if the distribution does not
support it out of the box.
Bug Fixes
A previous commit hardcoded many variables to the values under vars/,
making it impossible for the user to parameterize things like the systemd
service name. The assumption was that the _sshd* variables were useless
in an effort to blindly adhere to best practices, but they were crucial in
allowing flexibility to the user.
#188
This shouldn't be necessary, but there seems no way to
guarantee using a version of Jinja which doesn't have this
problem.
In addition - it is not good practice to compare values to
trueorfalse- instead, just ensure the value is abooltype and evaluate in a boolean context.
Other Changes
Fix various linting issues
Revert incorrect module name
tests: Do not be picky about spaces/tabs
When testing with cloud-init, it modifies the sshd_configuration and can
replace some tabs with whitespaces. This happens frequently around the
subsystem keyword. There are no functional changes, but the matching
did not work as expected.
Signed-off-by: Rich Megginson rmeggins@redhat.com