Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for ostree systems #270

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

richm
Copy link
Collaborator

@richm richm commented Nov 17, 2023

Feature: Allow running and testing the role with ostree managed nodes.

Reason: We have users who want to use the role to manage ostree
systems.

Result: Users can use the role to manage ostree managed nodes.
Signed-off-by: Rich Megginson rmeggins@redhat.com

@Jakuje
Copy link
Collaborator

Jakuje commented Nov 27, 2023

From the failing CI, the Fedora is fixed with top commit in #267, debian buster is probably just broken (can be ignored), but centos6 is something that should be fixed as part of this PR as the man-db requirement was introduced/changed here.

@richm
Copy link
Collaborator Author

richm commented Nov 27, 2023

From the failing CI, the Fedora is fixed with top commit in #267, debian buster is probably just broken (can be ignored), but centos6 is something that should be fixed as part of this PR as the man-db requirement was introduced/changed here.

ok - do you want to merge #267 then I can rebase?

@Jakuje
Copy link
Collaborator

Jakuje commented Nov 28, 2023

From the failing CI, the Fedora is fixed with top commit in #267, debian buster is probably just broken (can be ignored), but centos6 is something that should be fixed as part of this PR as the man-db requirement was introduced/changed here.

ok - do you want to merge #267 then I can rebase?

Whatever works for you. The #267 changes a lot of things, but they are not used by default so they should not be breaking (but some careful review would be needed). It does not have any deadlines as far as I know.

If the ostree support needs to land at some reasonable time, feel free to pull that particular commit from there into your PR.

Feature: Allow running and testing the role with ostree managed nodes.

Reason: We have users who want to use the role to manage ostree
systems.

Result: Users can use the role to manage ostree managed nodes.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm
Copy link
Collaborator Author

richm commented Nov 28, 2023

From the failing CI, the Fedora is fixed with top commit in #267, debian buster is probably just broken (can be ignored), but centos6 is something that should be fixed as part of this PR as the man-db requirement was introduced/changed here.

ok - do you want to merge #267 then I can rebase?

Whatever works for you. The #267 changes a lot of things, but they are not used by default so they should not be breaking (but some careful review would be needed). It does not have any deadlines as far as I know.

If the ostree support needs to land at some reasonable time, feel free to pull that particular commit from there into your PR.

ok - I just fixed the el6 issue - please review - then we can wait on #267 - I did not include that one in my PR - should keep them separate

@richm richm merged commit 195cb2e into willshersystems:main Nov 29, 2023
14 of 16 checks passed
@richm richm deleted the ostree branch November 29, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants