Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't work when using the fastify server #461

Closed
sinchang opened this issue Aug 24, 2020 · 2 comments · Fixed by #469
Closed

can't work when using the fastify server #461

sinchang opened this issue Aug 24, 2020 · 2 comments · Fixed by #469

Comments

@sinchang
Copy link
Contributor

Can we also support using the fastify server? thanks
@willsoto
Copy link
Owner

willsoto commented Aug 24, 2020 •
edited
Loading

I don't use Fastify, but someone originally tried to add support for it via #260, they just never saw it through to completion. I am happy to accept PRs. You need at least 1 test with all existing tests passing.

@sinchang sinchang mentioned this issue Aug 25, 2020
Merged
@willsoto
Copy link
Owner

Released as 0.1.3. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(*): add support for fastify AuroraSparkDev/nestjs-prometheus
2 participants
@willsoto @sinchang