Solved unicode problem some more #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore unconvertible unicode characters in sheet name and cell content
If present, show cell notes as <<...>> after cell content
Place cell coordinates (names) and contents into separate lines, such that a diff indicates inserted/deleted rows vs. actual content changes
|
Thanks for looking at this and sorry I have not replied earlier. I'll try to sort out some tests for the package so we can get automated better. |
willu47
added a commit
that referenced
this pull request
Aug 6, 2015
Solved unicode problem some more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore unconvertible unicode characters in sheet name and cell content
I had a spreadsheet with German umlauts in sheet names as well as umlauts and other Unicode characters in some cells, throwing UnicodeEncodeErrors. The proposed changes solved my problem.