Improve CI #22
Merged
Improve CI #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 82.25% 80.44% -1.81%
==========================================
Files 39 36 -3
Lines 3330 2890 -440
==========================================
- Hits 2739 2325 -414
+ Misses 591 565 -26
|
gpleiss
force-pushed
the
improve_testing
branch
18 times, most recently
from
5405a9c
to
0519e73
Compare
When jax is installed, any numpy array will use the jax_fns xnp backend. When jax is not installed, now all numpy arrays will use the np_fns xnp backend.
gpleiss
force-pushed
the
improve_testing
branch
from
0519e73
to
c4de357
Compare
gpleiss
commented
Aug 24, 2023
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ main ] |
There was a problem hiding this comment.
We used to run CI on all pull requests. For now I think it makes sense to just run it on main, but I could be convinced otherwise.
gpleiss
commented
Aug 24, 2023
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] |
There was a problem hiding this comment.
Here, I feel more strongly that CI should only be run on pushes to the main branch. We were running CI twice for PRs (once on branch push, once for the PR).
These markings make it possible to run the test suite when only one of the backends are installed. It also skips big operator tests on on CI. NOTE: for all future testing, neither torch, jax, cola.torch_fns, nor cola.jax_fns can be imported in a testing file. - With the 'not jax' mark, all non-jax tests run. - With the 'not torch' mark, all non-torch tests run. - With the 'not big' mark, all non-big LO tests run.
The unit tests are now run on 4 configurations: - jax installed only - torch (stable) installed only - torch (latest/unstable) installed only - both jax and torch are installed Codecov report is updated only for the jax + torch backend configuration. Other updates: - Set python-version to 3.10 to match minimum requirements - Only run CI on PRs/pushes to main branch
gpleiss
force-pushed
the
improve_testing
branch
from
c4de357
to
561f4b8
Compare
|
I will leave the "run example notebook smoke tests" task for a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
CI improvements
Run example notebook smoke testsNecessary fixes discovered by CI improvements