Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing typehint outputs #27

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

mfinzi
Copy link
Collaborator

@mfinzi mfinzi commented Aug 24, 2023

Type annotations on outputs of dispatched functions perform type conversion and this functionality is not intended for our usage. (Problems for parametric types are caused because e.g. Kronecker[A,B] doesn't match Kronecker and then plum attempts to perform a type conversion.

@dispatch
def fn(...) -> Kronecker:

Fix: remove type outputs on dispatched functions

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #27 (df858bd) into main (7496fd8) will not change coverage.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   82.20%   82.20%           
=======================================
  Files          39       39           
  Lines        3326     3326           
=======================================
  Hits         2734     2734           
  Misses        592      592           
Files Changed Coverage Δ
cola/fns.py 80.80% <100.00%> (ø)
cola/linalg/inverse.py 89.90% <100.00%> (ø)
cola/linalg/logdet.py 96.38% <100.00%> (ø)

@mfinzi mfinzi merged commit 7e108e5 into main Aug 24, 2023
5 of 7 checks passed
@mfinzi mfinzi deleted the remove-typehint-outputs-for-dispatched-fns branch August 25, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant