Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-documented phone number verification IsValid allowed value #9

Merged
merged 1 commit into from Apr 26, 2021

Conversation

lostie
Copy link
Contributor

@lostie lostie commented Apr 14, 2021

Loqate does not document that this is an allowed value for this property but it keeps returning responses with this value on it.

Dry::Types::ConstraintError: "Maybe" violates constraints (included_in?(["Yes", "No", "Unknown"], "Maybe") failed)

Loqate does not document that this is an allowed value for this property but it keeps return responses with this value on it
@lostie
Copy link
Contributor Author

lostie commented Apr 14, 2021

/cc @wilsonsilva for 👀

FYI, it seems the travis build error is related with this: jruby/jruby#6581

@lostie
Copy link
Contributor Author

lostie commented Apr 26, 2021

@wilsonsilva Thanks for reviewing!

It seems like:

  • Travis does not yet support the jruby version that fixes the build issue (9.2.16 is required)
  • the gemspec seems to be specific to the MRI version (spec.required_ruby_version = '>= 2.4.0').

Should we skip the jruby checks until both of those are addressed and they don't block the release of the new features?

@wilsonsilva
Copy link
Owner

@lostie Yeah, sounds good. Let's skip JRuby for the time being.

@wilsonsilva wilsonsilva merged commit cd91b4b into wilsonsilva:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants