Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Pool Ideal Range Value #14

Open
saboaua opened this issue Jun 8, 2023 · 3 comments
Open

Set Pool Ideal Range Value #14

saboaua opened this issue Jun 8, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@saboaua
Copy link

saboaua commented Jun 8, 2023

A good feature if you could set the value for the ideal range for your pool. If you have a salt pool, some values are different compare to a normal pool. Or you just want to have a slightly different range where you live.

@saboaua saboaua added the enhancement New feature or request label Jun 8, 2023
@wilsto
Copy link
Owner

wilsto commented Jun 11, 2023

hi @saboaua , you can already do it for each sensor : example here with salinity : https://github.com/wilsto/pool-monitor-card#salinity

@gregtakacs
Copy link

While you can set the ideal range, it's missing true customization. A single number for the mid-point and another one for the deviation is pretty basic.

For example, there is a good range of pH that is acceptable, ie. anything between 7.2-7.6 but I'd like my mid point to be 7.5 and I'd like to have anything lower than 7.1 marked as low but on the high I'm OK with it going as high as 7.8. This is currently not doable.

The most prominent issue is temperature: My pool here in the Texas summer can get as hot as 90F and I'd be swimming in as low as 70F. This puts my idael range at 20F but it also means I have temps as high as 110F displayed which is scorching hot tub temperature which I don't expect the pool to ever hit!

@romain563
Copy link

The recommandations are not apropriate for pools in France (https://www.legifrance.gouv.fr/jorf/texte_jo/JORFTEXT000043535394). There are also differences between exterior or interior pools
Others parameters are necessary for a good monitoring : combined chlorine, active chlorine...

Les bornes acceptables ne sont pas les valeurs recommandées par le code de la santé publique en France. Il serait bon que chacun puisse adapter les zones à ses spécificités régionales et à son type de piscine
Il faut également calculer le chlore libre actif qui dépends entre autre du pH et de la température.
Le calcul du chlore combiné est également important pour la santé.
La description des paramètres et leurs conséquences ne sont pas correctes dans le readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants