Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong response header HX-Push instead of HX-Push-Url used #69

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Wrong response header HX-Push instead of HX-Push-Url used #69

merged 1 commit into from
Sep 12, 2023

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Sep 12, 2023

checketts
checketts approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@checketts checketts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This was renamed in a beta branch that was never released.

@wimdeblauwe wimdeblauwe added this to the 3.1.0 milestone Sep 12, 2023
@wimdeblauwe wimdeblauwe self-requested a review September 12, 2023 18:59
@wimdeblauwe wimdeblauwe merged commit 6d09040 into wimdeblauwe:main Sep 12, 2023
1 check passed
@xhaggi xhaggi deleted the fix/hx-push-url branch September 13, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@checketts checketts checketts approved these changes

@wimdeblauwe wimdeblauwe Awaiting requested review from wimdeblauwe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xhaggi @checketts @wimdeblauwe