Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying modifiers in HX-Reswap #83

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add support for specifying modifiers in HX-Reswap #83

merged 2 commits into from
Oct 12, 2023

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Oct 9, 2023

No description provided.

@wimdeblauwe wimdeblauwe added this to the 3.1.0 milestone Oct 11, 2023
@xhaggi
Copy link
Contributor Author

xhaggi commented Oct 12, 2023

@wimdeblauwe I have addressed all your comments. Furthermore I have fixed the return type of HtmxResponse#getReswap which I had overlooked and added one more test.

@wimdeblauwe wimdeblauwe merged commit 9f1137a into wimdeblauwe:main Oct 12, 2023
1 check passed
@xhaggi xhaggi deleted the hx-reswap-modifiers branch October 13, 2023 06:28
@xhaggi xhaggi mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wimdeblauwe wimdeblauwe wimdeblauwe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xhaggi @wimdeblauwe