Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False ERROR on session start #152

Closed
abhishekbuyt opened this issue Aug 10, 2016 · 7 comments
Closed

False ERROR on session start #152

abhishekbuyt opened this issue Aug 10, 2016 · 7 comments
Milestone

Comments

@abhishekbuyt
Copy link

protected function initStorage()
{
    session_set_cookie_params(0);
    if ($this->id) {
        session_name($this->id);
    }
    session_start();
}

Error reported by as ----
The function session_start does not have a parameter options in PHP version 5.6 or earlier

@jrfnl
Copy link
Member

jrfnl commented Aug 10, 2016

Duplicate of #120 (which will be fixed soon - fixed locally already, PR upcoming)

@jrfnl
Copy link
Member

jrfnl commented Aug 10, 2016

PR #153 should fix this. Testing appreciated.

@abhishekbuyt
Copy link
Author

I have not been able to test it yet. waiting for the merge. Appreciate your fixing it.

I also had a feature request - ( output be grouped on basis of error type and a possible shell file generation that takes you through a set of particular errors. Will save tons of time in fixing incompatibilities and also prioritizing.)

I would love to contribute but i am not sure where the final output buffer is handled.

@jrfnl
Copy link
Member

jrfnl commented Aug 11, 2016

I also had a feature request - ( output be grouped on basis of error type and a possible shell file generation that takes you through a set of particular errors.

I suggest opening a separate issue for that.

@jrfnl
Copy link
Member

jrfnl commented Aug 19, 2016

As the fix has been merged, can this be closed now ?

@abhishekbuyt
Copy link
Author

Yup , Confirmed . The issue is no longer there.

@jrfnl
Copy link
Member

jrfnl commented Aug 19, 2016

👍

@jrfnl jrfnl added this to the 7.0.3 milestone Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants