Two new sniffs for Interfaces #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a method which will be introduced in PHPCS 2.7, but as PHPCompatibility supports PHPCS from 1.5x-2.6.0 at the moment, has to be copied in to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, Sniff to verify the use of interfaces against the PHP version in which they were introduced.
2. Sniff to verify that interfaces intended for PHP internal use are not being implemented in user land.
Sniff 1 also includes a check for unsupported methods, particularly that
__sleep()and__wakeup()are not defined within a class implementing theSerializableinterface as they would be ignored.All checks unit tested.
I've copied over a method which was added to PHPCS for the upcoming 2.7 release. If at some point PHPCompatibility would up the minimum PHPCS version to 2.7+, this method can be removed.
This has also been documented in the method doc block.