Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of additional ini directives & ability to indicate renamed directives #146

Merged
merged 10 commits into from Aug 6, 2016

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Aug 6, 2016

Add the ability to provide an alternative for renamed ini directives.

Example: the directive detect_unicode was renamed in PHP 5.4 to zend.detect_unicode.
With the code added now, an alternative can be added to the ini array and will be added to the message.

Review of the ini directives detected

  • Add a lot of additional ini directives to detect.
  • Added alternative name for a number of ini directives.
  • Corrected the introduction version for a few.
  • Re-ordered the ini directives to be alphabetical per version list.

Ref: http://php.net/manual/en/ini.list.php


See the individual commits for more information. I put those in to make reviewing easier and would suggest squashing them when merging.

The list is still not complete, but a lot more complete than it was before.

jrfnl added 10 commits August 6, 2016 08:44
Example: the directive `detect_unicode` was renamed in PHP 5.4 to `zend.detect_unicode`.

With the code added now, an `alternative` can be added to the ini array and will be added to the message.
* Add a lot of additional ini directives to detect.
* Added alternative name for a number of ini directives.

Ref: http://php.net/manual/en/ini.list.php
* Add a lot of additional ini directives to detect.
* Added alternative name for a number of ini directives.
* Corrected the introduction version for a few.

Ref: http://php.net/manual/en/ini.list.php
Also:
* Slight clarification in the property documentation for the deprecated directives and adjusted some values based on that.
* tabs vs spaces correction.
Also remove a duplicate directives and minor touch up.
Also fixed minor mix-up in the intro versions.
@wimg wimg merged commit 50932bb into PHPCompatibility:master Aug 6, 2016
@jrfnl jrfnl deleted the feature/renamed-ini-directives branch August 6, 2016 16:21
@jrfnl jrfnl added this to the 7.0.3 milestone Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants