Replace a lot of near duplicate unit test functions with data providers. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes maintenance of the unit tests easier if something would change and makes adding new unit tests a breeze. This change also makes the unit tests more complete as often only the 'error' case was tested and not the 'noViolation' case. This has now been rectified. The number of tests being run will be now also be reported more accurately. For this PR I have focused on the test files where the most advantage could be gained from using data providers. Additional changes: * Added a constant for the test file name and used that throughout the tests in the files I touched. * Add proper skip test indication for tests being skipped based on PHPCS version. * Renamed the `NewAnonymousClasses` test file (contained a typo). * Show deprecation for removed `ereg` extension and show `pcre` as an alternative. (`DeprecatedExtensions`) * Show removal for `ereg` and `mysql` functions. (`DeprecatedFunctions`). * Show deprecation for `mysqli` functions. (`DeprecatedFunctions`). * Corrected some version numbers. (`DeprecatedFunctions`). * Removed a few `setUp()` functions which did nothing but fall through to the parent. * A number of `noViolation` unit test cases for the `NonStaticMagicMethods` sniff existed, but most were not actually being tested. That's now corrected. * Some documentation improvements. This is a first iteration for refactoring of the unit tests. A further abstraction of a lot of these unit tests is definitely possible in the future.
|
Absolutely amazing ! |
|
Glad you like what I'm doing. |
|
PS.: what are you still doing up at this hour ? 😎 |
|
Look who's talking. You've been sending PRs in the middle of the night for the last week or so ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes maintenance of the unit tests easier if something would change and makes adding new unit tests a breeze.
This change also makes the unit tests more complete as often only the 'error' case was tested and not the 'noViolation' case. This has now been rectified.
The number of tests being run will now also be reported more accurately.
For this PR I have focused on the test files where the most advantage could be gained from using data providers.
Additional changes:
NewAnonymousClassestest file (contained a typo).eregextension and showpcreas an alternative. (DeprecatedExtensions)eregandmysqlfunctions. (DeprecatedFunctions).mysqlifunctions. (DeprecatedFunctions).DeprecatedFunctions).setUp()functions which did nothing but fall through to the parent.noViolationunit test cases for theNonStaticMagicMethodssniff existed, but most were not actually being tested. That's now corrected.This is a first iteration for refactoring of the unit tests.
A further abstraction of a lot of these unit tests is definitely possible in the future.