Add unit tests for the NewFunctions sniff. #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions in the `NewFunctions` sniff appeared not to be covered by unit tests. These have now been added. Also: * Make function name comparison case-insensitive as function calls are case-insensitive in PHP. * Exclude namespaced functions from this sniff (basic check). * Removed empty item from functions list * Added numerous extra functions to sniff for. Additionally some extra `noViolation` tests have been set up to make sure namespaced function calls will not be reported by this sniff. Removed the new methods which were mixed into the functions list as they can not be tested for in this way. Most cannot be called statically and if not called statically, there is little way to tell if the method belongs to that class.
jrfnl
force-pushed
the
feature/new-functions-unit-tests
branch
from
e66086f
to
1909338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions in the
NewFunctionssniff appeared not to be covered by unit tests.These have now been added.
Also:
Additionally some extra
noViolationtests have been set up to make sure namespaced function calls will not be reported by this sniff.Removed the new methods which were mixed into the functions list as they can not be tested for in this way. Most cannot be called statically and if not called statically, there is little way to tell if the method belongs to that class.