Improve removedFunctionParameters sniff. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add code to handle parameters which are first deprecated and only later removed. While a parameter is deprecated, but not yet removed, the sniff will show a warning instead of an error. * Add deprecation version for the existing parameter checks. * Add some additional removal parameters. * Minor rewrite of the actual error message. Includes unit tests and adjusted documentation. Question: the sniff name does no longer really cover what this sniff does. Should the sniff be renamed ? and if so, to what ? `DeprecatedFunctionParameters` ?
|
Good question. I've been planning to overhaul the names and set up a naming convention. There are some tests and test files that are incorrectly or even inconsistently named too. Let's leave it the way it is for now and fix it all in 1 go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes unit tests and adjusted documentation.
Question: the sniff name does no longer really cover what this sniff does. Should the sniff be renamed ? and if so, to what ?
DeprecatedFunctionParameters?