Improve DeprecatedPHP4StyleConstructors sniff (code review).
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bow out early when PHP7 does not have to be supported. * Defer to PHPCS native methods for determining the class and function names. * Don't trigger error for namespaced classes with a method with the same name as the class. > As of PHP 5.3.3, methods with the same name as the last element of a namespaced class name will no longer be treated as constructor. This change doesn't affect non-namespaced classes. Ref: http://php.net/manual/en/language.oop5.decon.php Includes unit test for namespaced class with same name method. Includes additional unit tests verifying the `noViolation` cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: http://php.net/manual/en/language.oop5.decon.php
Includes unit test for namespaced class with same name method.
Includes additional unit tests verifying the
noViolationcases.