Feature completeness NewScalarTypeDeclarations sniff (code review).
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/improve-type-declaration
branch
from
4c3332a
to
5d5fd8d
Compare
This adds a number of additional checks to the `NewScalarTypeDeclarations` sniff. * Check that type hints are not being used in pre-PHP 5.0 code. * Check for valid usage of the `array` and `callable` type hints. * Check for invalid type hints which are typical mistakes. * Check that the `self` type hint is only used within the class scope. Also: * The `description` key in the `$newTypes` array did not actually add any value, so I've removed it. * Minor tweaks to the original error message text. Was along the lines of: _"int type is not present in PHP version 5.6 or earlier"_. Now: _"'int' type declaration is not present in PHP version 5.6 or earlier"_. Includes unit tests covering all changes. This PR also adds two new utility methods to the abstract `PHPCompatibility_Sniff` class. One is a copy of an existing method from PHPCS with some minor tweaks which have been send in as a PR to PHPCS. That PR is expected to be merged for the 2.7.0 release. Unit tests for this method are available within the PHPCS test suite. The other is a new PHPCompatibility native method `inClassScope` and is accompanied by unit tests for the method. Similarly to an earlier PR, the file/sniff name does now no longer cover what the sniff actually does. File and sniff renaming advised.
jrfnl
force-pushed
the
feature/improve-type-declaration
branch
from
5d5fd8d
to
75f7799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a number of additional checks to the
NewScalarTypeDeclarationssniff.arrayandcallabletype hints.selftype hint is only used within the class scope.Ref: http://php.net/functions.arguments#functions.arguments.type-declaration
Also:
descriptionkey in the$newTypesarray did not actually add any value, so I've removed it.Includes unit tests covering all changes.
This PR also adds two new utility methods to the abstract
PHPCompatibility_Sniffclass.One is a copy of an existing method from PHPCS with some minor tweaks which have been send in as a PR to PHPCS. That PR is expected to be merged for the 2.7.0 release. Unit tests for this method are available within the PHPCS test suite.
The other is a new PHPCompatibility native method
inClassScope()and is accompanied by unit tests for the method.Similarly to an earlier PR, the file/sniff name does now no longer cover what the sniff actually does. File and sniff renaming advised.