Add new sniff to detect Late Static Binding. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Late static binding is only available on PHP 5.3 +. Ref: http://php.net/manual/en/language.oop5.late-static-bindings.php This sniff throws two new errors: 1. For LSB detected inside class/interface/trait scope and PHP < 5.3. 2. For LSB detected outside of class/interface/trait scope (not supported). Includes unit tests.
|
This is awesome! I had always assumed that this was the one new language feature that would be impossible to test for! :-) |
|
Turned out not to be that difficult, but I might be overlooking something. Please let me know if I've missed any typical situations which should be checked for (see the test cases in the unit tests). |
|
I'll log a ticket if I come across anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Late static binding is only available on PHP 5.3 +.
Ref: http://php.net/manual/en/language.oop5.late-static-bindings.php
This sniff throws two new errors:
Includes unit tests.