Fix false positives on assign-by-reference within function call in ForbiddenCallTimePassByReferenceSniff #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rbiddenCallTimePassByReferenceSniff While assigning to a variable within a function call or conditional might not be good practice, the reality is that there is plenty of userland code out there using it. This PR should fix false positives for variables being assigned by reference within function calls. It also should fix false positives for variables being compared by reference within function calls. Includes additional unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While assigning to a variable within a function call or conditional might not be good practice, the reality is that there is plenty of userland code out there using it.
This PR should fix false positives for variables being assigned by reference within function calls.
It also should fix false positives for variables being compared by reference within function calls.
Includes additional unit tests.
Refs:
http://php.net/manual/en/language.references.whatdo.php#language.references.whatdo.assign
http://php.net/manual/en/language.operators.assignment.php#40084
Fixes #68 (comment)
Fixes #68 (comment)
/cc @octalmage