Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewExecutionDirectives sniff: minor efficiency tweak. #360

Merged
merged 1 commit into from Feb 28, 2017
Merged

NewExecutionDirectives sniff: minor efficiency tweak. #360

merged 1 commit into from Feb 28, 2017

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Feb 28, 2017

The list returned by mb_list_encodings() is not going to change during the PHPCS run, so we might as well cache it in a local static variable.

@jrfnl
NewExecutionDirectives sniff: minor efficiency tweak.
80ac8aa 
The list returned by `mb_list_encodings()` is not going to change during the PHPCS run, so we might as well cache it in a local static variable.
@coveralls
Copy link

coveralls commented Feb 28, 2017 •
edited

Coverage Status

Coverage decreased (-0.004%) to 95.733% when pulling 80ac8aa on jrfnl:feature/execution-directive-efficiency-tweak into 9c62e59 on wimg:master.

@wimg wimg merged commit 824b81c into PHPCompatibility:master Feb 28, 2017
@jrfnl jrfnl deleted the feature/execution-directive-efficiency-tweak branch February 28, 2017 20:15
@jrfnl jrfnl added this to the 7.1.3 milestone May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chores/QA
Projects
None yet
Milestone
7.1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrfnl @coveralls @wimg