Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PHPCS whitespaces #543

Merged
merged 2 commits into from Dec 14, 2017
Merged

Fixed PHPCS whitespaces #543

merged 2 commits into from Dec 14, 2017

Conversation

wimg
Copy link
Member

@wimg wimg commented Dec 13, 2017

No description provided.

@wimg wimg added this to the 8.1.0 milestone Dec 13, 2017
@wimg wimg requested a review from jrfnl December 13, 2017 18:54
jrfnl
jrfnl approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Interesting that those didn't get flagged by PHPCS in the build for #542.

@jrfnl jrfnl merged commit 4c7abf1 into master Dec 14, 2017
@jrfnl jrfnl deleted the fix-phpcs branch December 14, 2017 00:54
@jrfnl
Copy link
Member

jrfnl commented Dec 14, 2017

Ah! Those were in the new sniff which was merged in between. Never mind. Glad it's sorted now.

@jrfnl jrfnl mentioned this pull request Dec 17, 2017
Merged
@dependencies dependencies bot mentioned this pull request Dec 28, 2017
Merged
@jrfnl jrfnl added the chores/QA label Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
chores/QA
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wimg @jrfnl