Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=Rough initial work on addressing issue #5 - Abstract form AJAX handling #6

Merged
merged 3 commits into from Oct 6, 2012

Conversation

frega
Copy link
Collaborator

@frega frega commented Oct 1, 2012

The patch does some refactoring of the ajax-related handling as indicated in issue #5 of the main repo. It implicitly also fixes/addresses issue #4.

This is still very rough on the edges and an incomplete refactoring (in particular in ui-editable.js).

What works now/still works:

  • form-based fields.
  • body field (aloha) seems to work mostly (some ui glitches, some formattings aren't saved).
  • title field works sort of (several issues)

What does not work:

  • title editable: saving "kind of works" but there's double encoding & there's weird whitespace issues (leading to "length" validation erros); this probably has to do w/ so-far the missing "edit_field_rendered_without_transformation_filters"-implementation.
  • title editable: save/submit returns an empty response.data.
  • authoring date editable: is correctly "editable" but the form response renders incorrectly (or rather renders the "user name").
  • body editable (aloha): sometimes toolbars don't get initialized, visible etc. inline-styles are ignored (could be drupal-input format settting).
  • validation (no handling at all)
  • i think i've messed up the distinction between $field and $editable in the form-editable-response injection, but it seems to work nonetheless ...

Bug/quirks/kinks:

  • all editables: saving properly re-enables the editable, leaving the editable by activating another editable or clicking cancel permanently disables it (might be just some missing CSS classes, might be something else).
  • if you toggle between view and edit modes, editables get repadded/redecorated.

wimleers added a commit that referenced this pull request Oct 6, 2012
=Rough initial work on addressing issue #5 - Abstract form AJAX handling
@wimleers wimleers merged commit cc913db into wimleers:7.x-1.x Oct 6, 2012
@wimleers
Copy link
Owner

wimleers commented Oct 6, 2012

Please see my ecstatic comment in #5#5 (comment) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants