problem at line 185 of deb-get script

[peutch]

Hi,

the cited line is:

if ! "${ELEVATE}" wget -q --no-use-server-timestamps "${1}" -O "${CACHE_FILE}"; then

and I think that it should be:

if ! ${ELEVATE} wget -q --no-use-server-timestamps "${1}" -O "${CACHE_FILE}"; then

otherwise when ${ELEVATE} is empty the test be always true.

[philclifford]

hmmm ... good spot

if ! "$ELEVATE" echo oops ; then echo fail;else echo not fail;fi
Command '' not found, but can be installed with:
sudo apt install mailutils-mh  # version 1:3.15-2, or
sudo apt install mmh           # version 0.4-4
sudo apt install nmh           # version 1.7.1-12
sudo apt install termtris      # version 1.3-1ubuntu1
fail # <--
$ if ! "$ELEVATE echo oops" ; then echo fail;else echo not fail;fi
 echo oops: command not found
fail # <--
 $ if ! $ELEVATE echo oops ; then echo fail;else echo not fail;fi
oops
not fail  # <--

subtle because it only gets set to "" if we call elevate_privs as root already and otherwise it is set to sudo or doas or we bail.